Hi Rob, Thanks for the review of v1. I managed to add regulator support. Exploiting the explicit pattern, I have used protocol@*, to make #*-cells as required. Lots of repeated schema except the #*-cells, not sure if there is any better way to collapse or take the common out. Regards, Sudeep v1->v2: - Fixed wrongly used "arm,scpi-shmem" with correct "arm,scp-shmem" - Fixed support for "arm,scpi-pre-1.0" only - Added example for amlogic,meson-gxbb-scpi - Added regulator support, expanded all the protocol@* patters to mark #*-cells as required property Sudeep Holla (8): dt-bindings: firmware: arm,scpi: Move arm,scp-shmem to json schema dt-bindings: firmware: arm,scmi: Move arm,scmi-shmem to json schema dt-bindings: firmware: juno,scpi: Move to sram.yaml json schema dt-bindings: firmware: amlogic,scpi: Move arm,scpi-shmem to json schema dt-bindings: mailbox : arm,mhu: Fix arm,scpi example used here dt-bindings: firmware: arm,scpi: Convert to json schema dt-bindings: firmware: amlogic,scpi: Convert to json schema dt-bindings: firmware: arm,scmi: Convert to json schema .../devicetree/bindings/arm/amlogic,scpi.txt | 27 - .../devicetree/bindings/arm/arm,scmi.txt | 239 --------- .../devicetree/bindings/arm/arm,scpi.txt | 219 -------- .../devicetree/bindings/arm/juno,scpi.txt | 26 - .../bindings/firmware/arm,scmi.yaml | 474 ++++++++++++++++++ .../bindings/firmware/arm,scpi.yaml | 317 ++++++++++++ .../devicetree/bindings/mailbox/arm,mhu.yaml | 10 +- .../devicetree/bindings/sram/sram.yaml | 5 + MAINTAINERS | 2 +- 9 files changed, 805 insertions(+), 514 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/amlogic,scpi.txt delete mode 100644 Documentation/devicetree/bindings/arm/arm,scmi.txt delete mode 100644 Documentation/devicetree/bindings/arm/arm,scpi.txt delete mode 100644 Documentation/devicetree/bindings/arm/juno,scpi.txt create mode 100644 Documentation/devicetree/bindings/firmware/arm,scmi.yaml create mode 100644 Documentation/devicetree/bindings/firmware/arm,scpi.yaml -- 2.25.1