Re: [PATCH v2] dt-bindings: net: Convert MDIO mux bindings to DT schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 26, 2021 at 1:51 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> On Wed, May 26, 2021 at 01:14:11PM -0500, Rob Herring wrote:
> > Convert the common MDIO mux bindings to DT schema.
> >
> > Drop the example from mdio-mux.yaml as mdio-mux-gpio.yaml has the same one.
> >
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> > Cc: Ray Jui <rjui@xxxxxxxxxxxx>
> > Cc: Scott Branden <sbranden@xxxxxxxxxxxx>
> > Cc: bcm-kernel-feedback-list@xxxxxxxxxxxx
> > Cc: Andrew Lunn <andrew@xxxxxxx>
> > Cc: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> > Cc: Russell King <linux@xxxxxxxxxxxxxxx>
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
>
> > +        mdio@2 {  // Slot 2 XAUI (FM1)
> > +            reg = <2>;
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +
> > +            ethernet-phy@4 {
> > +                compatible = "ethernet-phy-ieee802.3-c45";
> > +                reg = <0>;
>
> reg should really be 4 here. The same error existed in the .txt

Will fixup.

> version. I guess the examples are never actually verified using the
> yaml?

They are verified in general, but for this specific check it is dtc
that does it and only for bus types that it knows about. MDIO isn't
one of them.

Rob



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux