Hi Benjamin, I love your patch! Yet something to improve: [auto build test ERROR on iommu/next] [also build test ERROR on rockchip/for-next robh/for-next v5.13-rc3 next-20210525] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Benjamin-Gaignard/Add-IOMMU-driver-for-rk356x/20210525-201749 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next config: arm-randconfig-r025-20210525 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/0day-ci/linux/commit/bd6c989c628be7c8ac1f8aeb9f301bd3a6e0a078 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Benjamin-Gaignard/Add-IOMMU-driver-for-rk356x/20210525-201749 git checkout bd6c989c628be7c8ac1f8aeb9f301bd3a6e0a078 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/iommu/rockchip-iommu.c:1384:19: error: use of undeclared identifier 'rk_dma_addr_dte'; did you mean 'rk_dma_addr_dte_v2'? .dma_addr_dte = &rk_dma_addr_dte, ^~~~~~~~~~~~~~~ rk_dma_addr_dte_v2 drivers/iommu/rockchip-iommu.c:551:19: note: 'rk_dma_addr_dte_v2' declared here static inline u32 rk_dma_addr_dte_v2(dma_addr_t dt_dma) ^ 1 error generated. vim +1384 drivers/iommu/rockchip-iommu.c 0f181d3cf7d984b Jeffy Chen 2018-03-23 1378 ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1379 static struct rk_iommu_ops iommu_data_ops_v1 = { ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1380 .pt_address = &rk_dte_pt_address, ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1381 .mk_dtentries = &rk_mk_dte, ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1382 .mk_ptentries = &rk_mk_pte, ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1383 .dte_addr_phys = &rk_dte_addr_phys, ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 @1384 .dma_addr_dte = &rk_dma_addr_dte, ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1385 .dma_bit_mask = DMA_BIT_MASK(32), ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1386 }; ce0eeece4c9ef42 Benjamin Gaignard 2021-05-25 1387 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
