Hi Krzysztof, > -----Original Message----- > From: Krzysztof Wilczyński <kw@xxxxxxxxx> > Sent: Monday, May 24, 2021 4:00 PM > To: Thokala, Srikanth <srikanth.thokala@xxxxxxxxx> > Cc: robh+dt@xxxxxxxxxx; lorenzo.pieralisi@xxxxxxx; linux- > pci@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > andriy.shevchenko@xxxxxxxxxxxxxxx; mgross@xxxxxxxxxxxxxxx; Raja > Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@xxxxxxxxx>; > Sangannavar, Mallikarjunappa <mallikarjunappa.sangannavar@xxxxxxxxx> > Subject: Re: [PATCH v9 2/2] PCI: keembay: Add support for Intel Keem Bay > > Hi Srikanth, > > Everything looks very good! > > [...] > > + ret = devm_add_action_or_reset(dev, > > + (void(*)(void *))clk_disable_unprepare, > > + clk); > [...] > > Just a small note (no need to change anything) about the above. Some > drivers add a small wrapper function around the clk_disable_unprepare() > to avoid having to do this case above which is also easier to read as > a result. But, this is just a matter of whether it's needed (e.g., some > extra steps would be needed to disable clocks, etc.) and personal > preference. I will make a note of your suggestion, thank you. > > Thank you for working on this! > > Reviewed-by: Krzysztof Wilczyński <kw@xxxxxxxxx> Thank you, Krzysztof, for the "Reviewed-by". Srikanth > > Krzysztof
