Hi Srikanth, Everything looks very good! [...] > + ret = devm_add_action_or_reset(dev, > + (void(*)(void *))clk_disable_unprepare, > + clk); [...] Just a small note (no need to change anything) about the above. Some drivers add a small wrapper function around the clk_disable_unprepare() to avoid having to do this case above which is also easier to read as a result. But, this is just a matter of whether it's needed (e.g., some extra steps would be needed to disable clocks, etc.) and personal preference. Thank you for working on this! Reviewed-by: Krzysztof Wilczyński <kw@xxxxxxxxx> Krzysztof
