> > > > Hi Lee > > > > Thanks for taking your time to review my code. I will start working on > > the core driver. But Kconfig items will stay as MFD_RSMU_I2C and > > MFD_RSMU_SPI like the existing ones > > > > MFD_MADERA_SPI > > MFD_MADERA_I2C > > And MFD_MADERA > > > MFD_DA9052_SPI > > MFD_DA9052_I2C > > And PMIC_DA9052 > > > MFD_MC13XXX_SPI > > MFD_MC13XXX_I2C > > And MFD_MC13XXX > Hi Lee I think I don't need separate Kconfig item MFD_RSMU for core driver since core driver is meaningless without bus underneath. So can I go with the following example rsmu-i2c-objs := rsmu_core.o rsmu_i2c.o obj-$(CONFIG_ MFD_RSMU_I2C) += rsmu-i2c.o Thanks Min