> > > > +config MFD_RSMU_I2C > > + tristate "Renesas Synchronization Management Unit with I2C" > > + depends on I2C && OF > > + depends on MFD_RSMU_SPI=n > > Not sure I've seen a relationship like this before. > > Devices capable of SPI and I2C usually have a core driver which selects one > or the other. It will also save some code duplication you have here. Please > take a look at some other examples in the MFD subsystem. Hi Lee Thanks for taking your time to review my code. I will start working on the core driver. But Kconfig items will stay as MFD_RSMU_I2C and MFD_RSMU_SPI like the existing ones MFD_MADERA_SPI MFD_MADERA_I2C MFD_DA9052_SPI MFD_DA9052_I2C MFD_MC13XXX_SPI MFD_MC13XXX_I2C Min
