Hi Mark, On Tue, Jul 15, 2014 at 2:29 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote: > On Tue, Jul 15, 2014 at 07:39:40AM +0100, Harini Katakam wrote: >> Hi Mark, >> >> On Mon, Jul 14, 2014 at 8:37 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote: >> > On Mon, Jul 14, 2014 at 01:16:09PM +0100, Harini Katakam wrote: >> >> Add cadence-wdt bindings documentation. >> >> >> >> Signed-off-by: Harini Katakam <harinik@xxxxxxxxxx> >> >> --- >> >> >> >> v3 changes: >> >> - Change reset property type and improve description. >> >> - Improve description of clocks and interrupts. >> >> - Use watchdog@ in the example. >> >> - Use only cdns compatible string for now. >> >> >> >> v2: >> >> No changes >> >> >> >> --- >> >> .../devicetree/bindings/watchdog/cadence-wdt.txt | 27 ++++++++++++++++++++ >> >> 1 file changed, 27 insertions(+) >> >> create mode 100644 Documentation/devicetree/bindings/watchdog/cadence-wdt.txt >> >> <snip> >> >> +Optional properties >> >> +- reset : If this property exists, then a reset is done >> >> + when watchdog times out. >> > >> > That's a bit of an ambiguous name (too easy to misconstrue as a reset >> > device reference). Do any other watchdogs have similar properties? >> >> I could change it to "reset-on-timeout" if that better. >> From the documentation of other drivers, there seems to be a reset-type >> property in atmel. Dint find any other reset related properties. >> > > Ok. reset-on-timeout sounds like a better property name to avoid > possible confusion. > > That said, what happens if we don't specify the device should reset the > system (but have a timeout-sec property)? > A reset wont be done but a message will be printed when the watchdog times out just as an indication. Regards, Harini -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
