On Fri, Apr 23, 2021 at 02:00:46PM +0800, Greentime Hu wrote: > Palmer Dabbelt <palmer@xxxxxxxxxxx> 於 2021年4月23日 週五 下午1:10寫道： > > > > On Thu, 22 Apr 2021 21:43:03 PDT (-0700), Palmer Dabbelt wrote: > > > On Sun, 11 Apr 2021 19:37:50 PDT (-0700), greentime.hu@xxxxxxxxxx wrote: > > >> Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> 於 2021年4月9日 週五 下午4:54寫道： > > >>> > > >>> On Tue, 6 Apr 2021 17:26:28 +0800, Greentime Hu wrote: > > >>> > This patchset includes SiFive FU740 PCIe host controller driver. We also > > >>> > add pcie_aux clock and pcie_power_on_reset controller to prci driver for > > >>> > PCIe driver to use it. > > >>> > > > >>> > This is tested with e1000e: Intel(R) PRO/1000 Network Card, AMD Radeon R5 > > >>> > 230 graphics card and SP M.2 PCIe Gen 3 SSD in SiFive Unmatched based on > > >>> > v5.11 Linux kernel. > > >>> > > > >>> > [...] > > >>> > > >>> Applied to pci/dwc [dropped patch 6], thanks! > > >>> > > >>> [1/6] clk: sifive: Add pcie_aux clock in prci driver for PCIe driver > > >>> https://git.kernel.org/lpieralisi/pci/c/f3ce593b1a > > >>> [2/6] clk: sifive: Use reset-simple in prci driver for PCIe driver > > >>> https://git.kernel.org/lpieralisi/pci/c/0a78fcfd3d > > >>> [3/6] MAINTAINERS: Add maintainers for SiFive FU740 PCIe driver > > >>> https://git.kernel.org/lpieralisi/pci/c/8bb1c66a90 > > >>> [4/6] dt-bindings: PCI: Add SiFive FU740 PCIe host controller > > >>> https://git.kernel.org/lpieralisi/pci/c/b86d55c107 > > >>> [5/6] PCI: fu740: Add SiFive FU740 PCIe host controller driver > > >>> https://git.kernel.org/lpieralisi/pci/c/327c333a79 > > >>> > > >>> Thanks, > > >>> Lorenzo > > >> > > >> Hi Palmer, > > >> > > >> Since the PCIE driver has been applied, would you please pick patch 6 > > >> to RISC-V for-next tree? > > >> Thank you. :) > > > > > > Sorry, I got this confused between the Linux patch set and the u-boot > > > patch set so I thought more versions of this had kept comming. The DT > > > is on for-next now. > > > > I spoke too soon: this actually dosn't even build for me. It's the > > "clocks = <&prci PRCI_CLK_PCIE_AUX>;" line > > > > Error: arch/riscv/boot/dts/sifive/fu740-c000.dtsi:319.20-21 syntax error > > FATAL ERROR: Unable to parse input tree > > make[2]: *** [scripts/Makefile.lib:336: arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb] Error 1 > > make[1]: *** [scripts/Makefile.build:514: arch/riscv/boot/dts/sifive] Error 2 > > make: *** [Makefile:1388: dtbs] Error 2 > > make: *** Waiting for unfinished jobs.... > > > > I'm not sure what the issue is, I see an anchor for "prci". Do you mind > > sending along a new version that compiles on top of for-next? If I need > > the definiton of PRCI_CLK_PCIE_AUX from a PCIe tree then it's probably > > best to just keep the DTS along with the rest of the patches. IIRC I > > alredy Acked it, but just to be clear > > > > Acked-by: Palmer Dabbelt <palmerdabbelt@xxxxxxxxxx> > > > > Thanks! > > Thank you, Palmer. > It is defined in the first commit of this patchset. "clk: sifive: Add > pcie_aux clock in prci driver for PCIe driver" > You can select these whole 6 patches to make sure it can be built. > > Hi Lorenzo, > Would you mind to pick the 6th patch along with the other 5 patches? > Thank you. Done, on my pci/dwc branch. Thanks, Lorenzo
