Re: [PATCH V3] dt-bindings: mtd: brcm,brcmnand: convert to the json-schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 20, 2021 at 2:20 PM Rafał Miłecki <zajec5@xxxxxxxxx> wrote:
>
> From: Rafał Miłecki <rafal@xxxxxxxxxx>
>
> This helps validating DTS files.

I gotta learn how to read this stuff better someday... but I'll give it a shot:

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> @@ -0,0 +1,242 @@
...
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: brcm,nand-iproc
> +    then:
> +      properties:
> +        reg-names:
> +          minItems: 2
> +          maxItems: 3
> +          items:
> +            - const: nand
> +            - const: iproc-idm
> +            - const: iproc-ext

Reading the original binding as well as the code, I believe all three
are required. Wouldn't that be minItems = maxItems = 3?

Other than that, this looks good to me:

Reviewed-by: Brian Norris <computersforpeace@xxxxxxxxx>

Thanks!




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux