> +int lan937x_reset_switch(struct ksz_device *dev) > +{ > + u32 data32; > + u8 data8; > + int rc; > + > + /* reset switch */ > + rc = lan937x_cfg(dev, REG_SW_OPERATION, SW_RESET, true); > + if (rc < 0) > + return rc; Please consistently use ret everywhere, not rc. Andrew