On Tue, Apr 20, 2021 at 3:26 AM Andrew Lunn <andrew@xxxxxxx> wrote: > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + phy1: phy@1 { > > + #phy-cells = <0>; > > Hi Linus > > phy-cells is not part of the Ethernet PHY binding. Nevertheless: CHECK Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.example.dt.yaml /var/linus/linux-nomadik/build-ixp4/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.example.dt.yaml: phy@1: '#phy-cells' is a required property From schema: /home/linus/.local/lib/python3.9/site-packages/dtschema/schemas/phy/phy-provider.yaml It has been hardcoded as required into the dtschema python package. Looks like this: properties: $nodename: pattern: "^(|usb-|usb2-|usb3-|pci-|pcie-|sata-)phy(@[0-9a-f,]+)*$" "#phy-cells": true phy-supply: true required: - "#phy-cells" additionalProperties: true If this is wrong I bet Rob needs to hear about it. Yours, Linus Walleij