On Mon, Apr 19, 2021 at 07:09:56AM +1000, Alistair Francis wrote: > Add support for the 10.3" E Ink panel described at: > https://www.eink.com/product.html?type=productdetail&id=7 > > Signed-off-by: Alistair Francis <alistair@xxxxxxxxxxxxx> > --- > drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 4e2dad314c79..f1f6fd2517f6 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1964,6 +1964,32 @@ static const struct panel_desc edt_etm0700g0bdh6 = { > .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > }; > > +static const struct display_timing eink_vb3300_kca_timing = { > + .pixelclock = { 40000000, 40000000, 40000000 }, > + .hactive = { 334, 334, 334 }, > + .hfront_porch = { 1, 1, 1 }, > + .hback_porch = { 1, 1, 1 }, > + .hsync_len = { 1, 1, 1 }, > + .vactive = { 1405, 1405, 1405 }, > + .vfront_porch = { 1, 1, 1 }, > + .vback_porch = { 1, 1, 1 }, > + .vsync_len = { 1, 1, 1 }, > + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW | > + DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE, > +}; > + > +static const struct panel_desc eink_vb3300_kca = { > + .modes = &edt_etm0700g0dh6_mode, > + .num_modes = 1, > + .bpc = 6, > + .size = { > + .width = 157, > + .height = 209, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > +}; > + > static const struct display_timing evervision_vgg804821_timing = { > .pixelclock = { 27600000, 33300000, 50000000 }, > .hactive = { 800, 800, 800 }, > @@ -4232,6 +4258,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "edt,etm0700g0dh6", > .data = &edt_etm0700g0dh6, > + }, { > + .compatible = "eink,vb3300-kca", You have to document this string too.