On Wed, Apr 21, 2021 at 12:17:27PM -0500, Rob Herring wrote: > On Wed, Apr 21, 2021 at 06:20:26PM +0200, Thomas Bogendoerfer wrote: > > Add YAML devicetree binding for IDT 79RC3243x GPIO controller > > > > Signed-off-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > > --- > > .../bindings/gpio/gpio-idt3243x.yaml | 73 +++++++++++++++++++ > > Use compatible string for filename. ok > > 1 file changed, 73 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-idt3243x.yaml > > > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-idt3243x.yaml b/Documentation/devicetree/bindings/gpio/gpio-idt3243x.yaml > > new file mode 100644 > > index 000000000000..346a57ef8298 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/gpio-idt3243x.yaml > > @@ -0,0 +1,73 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/gpio/gpio-idt3243x.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: IDT 79RC32434x GPIO controller > > + > > +maintainers: > > + - Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + const: idt,3243x-gpio > > What's the 'x'? Generally, we don't do wildcards for compatible strings. there are 3 different SoCs 79rc32434, 79rc32435 and 79rc32438. So should I add 3 compatible strings and use the first as filename ? > > + ngpios: > > + description: > > + Number of available gpios in a bank. > > That's every 'ngpios'. Drop. ok. > > +additionalProperties: false > > + > > +examples: > > + - | > > + gpio0: interrupt-controller@50000 { > > gpio@... > > As generally it's primarily a GPIO controller and secondarily an > interrupt controller. ok. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
