On Wed, Apr 21, 2021 at 06:20:26PM +0200, Thomas Bogendoerfer wrote: > Add YAML devicetree binding for IDT 79RC3243x GPIO controller > > Signed-off-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > --- > .../bindings/gpio/gpio-idt3243x.yaml | 73 +++++++++++++++++++ Use compatible string for filename. > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-idt3243x.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-idt3243x.yaml b/Documentation/devicetree/bindings/gpio/gpio-idt3243x.yaml > new file mode 100644 > index 000000000000..346a57ef8298 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/gpio-idt3243x.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/gpio-idt3243x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: IDT 79RC32434x GPIO controller > + > +maintainers: > + - Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > + > +properties: > + compatible: > + const: idt,3243x-gpio What's the 'x'? Generally, we don't do wildcards for compatible strings. > + > + reg: > + maxItems: 2 > + > + reg-names: > + items: > + - const: gpio > + - const: pic > + > + gpio-controller: true > + > + "#gpio-cells": > + const: 2 > + > + ngpios: > + description: > + Number of available gpios in a bank. That's every 'ngpios'. Drop. > + minimum: 1 > + maximum: 32 > + > + interrupt-controller: true > + > + "#interrupt-cells": > + const: 2 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - reg-names > + - gpio-controller > + - "#gpio-cells" > + - ngpios > + - interrupt-controller > + - "#interrupt-cells" > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + gpio0: interrupt-controller@50000 { gpio@... As generally it's primarily a GPIO controller and secondarily an interrupt controller. > + compatible = "idt,3243x-gpio"; > + reg = <0x50000 0x14>, <0x38030 0x0c>; > + reg-names = "gpio", "pic"; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + > + interrupt-parent = <&cpuintc>; > + interrupts = <6>; > + > + gpio-controller; > + #gpio-cells = <2>; > + > + ngpios = <14>; > + }; > -- > 2.29.2 >
