Hi, On Sat, Apr 17, 2021 at 05:37:28PM +0200, Uwe Kleine-König wrote: > On Mon, Apr 12, 2021 at 03:27:38PM +0200, Clemens Gruber wrote: > > The switch to the atomic API goes hand in hand with a few fixes to > > previously experienced issues: > > - The duty cycle is no longer lost after disable/enable (previously the > > OFF registers were cleared in disable and the user was required to > > call config to restore the duty cycle settings) > > - If one sets a period resulting in the same prescale register value, > > the sleep and write to the register is now skipped > > - Previously, only the full ON bit was toggled in GPIO mode (and full > > OFF cleared if set to high), which could result in both full OFF and > > full ON not being set and on=0, off=0, which is not allowed according > > to the datasheet > > - The OFF registers were reset to 0 in probe, which could lead to the > > forbidden on=0, off=0. Fixed by resetting to POR default (full OFF) > > I didn't recheck all details, but the patch is definitively an > improvement, so: > > Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Thanks, but there is a newer version v9, I assume your acks are meant for the newer one? Clemens
