On Mon, Apr 12, 2021 at 06:30:54PM +0300, bpeled@xxxxxxxxxxx wrote: > From: Ben Peled <bpeled@xxxxxxxxxxx> > > Adding optional system-controller and mac-reset-bit-mask > needed for linkdown procedure. > > Signed-off-by: Ben Peled <bpeled@xxxxxxxxxxx> > --- > Documentation/devicetree/bindings/pci/pci-armada8k.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/pci-armada8k.txt b/Documentation/devicetree/bindings/pci/pci-armada8k.txt > index 7a813d0..2696e79 100644 > --- a/Documentation/devicetree/bindings/pci/pci-armada8k.txt > +++ b/Documentation/devicetree/bindings/pci/pci-armada8k.txt > @@ -24,6 +24,10 @@ Optional properties: > - phy-names: names of the PHYs corresponding to the number of lanes. > Must be "cp0-pcie0-x4-lane0-phy", "cp0-pcie0-x4-lane1-phy" for > 2 PHYs. > +- marvell,system-controller: address of system controller needed > + in order to reset MAC used by link-down handle > +- marvell,mac-reset-bit-mask: MAC reset bit of system controller > + needed in order to reset MAC used by link-down handle Seems like this should use the reset controller binding instead. If not, this can be a single property with a phandle plus arg. Rob