Hello, one more comment: On Sat, Apr 10, 2021 at 08:08:37AM +0900, Nobuhiro Iwamatsu wrote: > +static inline struct visconti_pwm_chip *to_visconti_chip(struct pwm_chip *chip) all functions but this one start have the common prefix "visconti_pwm_". I like the concept of a common prefix and so you could rename this function to visconti_pwm_from_chip or similar. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
