Hello Clemens, On Wed, Apr 07, 2021 at 10:47:45PM +0200, Clemens Gruber wrote: > On Wed, Apr 07, 2021 at 08:16:19AM +0200, Uwe Kleine-König wrote: > > You didn't check all return codes? How did you select the calls to > > check? > > No, because it would become a big mess and really obstruct readability > in my opinion. > > So I chose some kind of middleground: > I decided to check the first regmap_read and regmap_write in probe and > return the error code if something goes wrong there. > If something goes wrong after probe, I only print an error message. > > Is that acceptable? I wanted to have that in the commit log, but just noticed that I didn't read it carefully enough, it's already there. So if you change %d in the error messages to %pe I'm happy with this patch. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
