On Fri, Mar 19, 2021 at 9:06 AM Marco Felsch <m.felsch@xxxxxxxxxxxxxx> wrote: > > Hi Alistair, > > the patch looks quite good only a few notes inline. > > PS: It would be cool to have a log to previous patch versions. I'm not sure how I could add that, I will add a changelog for this version though. > > On 21-03-15 22:27, Alistair Francis wrote: > > ... > > > +&crypto { > > + status = "disabled"; > > +}; > > Why do you disable the crypto subsystem? > > > +&dma_apbh { > > + status = "disabled"; > > +}; > > Why do you disable this dma controller? > > > + > > +&sdma { > > + status = "okay"; > > +}; > > This is the default state so you can drop this node. You are right, these are all just left over from the vendor DT, I have removed all 3. Alistair > > Regards, > Marco