Hi Vinod, On 3/2/21 15:43, Vinod Koul wrote: > Add driver for the Qualcomm interconnect buses found in SM8i350 based Still SM8i350? Have you checked my comments on v1? > platforms. The topology consists of several NoCs that are controlled by > a remote processor that collects the aggregated bandwidth for each > master-slave pairs. > > Generated from downstream interconnect driver written by David Dai > > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> > --- > drivers/interconnect/qcom/Kconfig | 10 + > drivers/interconnect/qcom/Makefile | 2 + > drivers/interconnect/qcom/sm8350.c | 636 +++++++++++++++++++++++++++++ > drivers/interconnect/qcom/sm8350.h | 168 ++++++++ > 4 files changed, 816 insertions(+) > create mode 100644 drivers/interconnect/qcom/sm8350.c > create mode 100644 drivers/interconnect/qcom/sm8350.h > > diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig > index ca52647f8955..836157d97cae 100644 > --- a/drivers/interconnect/qcom/Kconfig > +++ b/drivers/interconnect/qcom/Kconfig > @@ -110,5 +110,15 @@ config INTERCONNECT_QCOM_SM8250 > This is a driver for the Qualcomm Network-on-Chip on sm8250-based > platforms. > > +config INTERCONNECT_QCOM_SM8350 > + tristate "Qualcomm SM8350 interconnect driver" > + depends on INTERCONNECT_QCOM > + depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST Again: depends on INTERCONNECT_QCOM_RPMH_POSSIBLE > + select INTERCONNECT_QCOM_RPMH > + select INTERCONNECT_QCOM_BCM_VOTER > + help > + This is a driver for the Qualcomm Network-on-Chip on SM8350-based > + platforms. > + > config INTERCONNECT_QCOM_SMD_RPM > tristate > diff --git a/drivers/interconnect/qcom/Makefile b/drivers/interconnect/qcom/Makefile > index c6a735df067e..93d97e590836 100644 > --- a/drivers/interconnect/qcom/Makefile > +++ b/drivers/interconnect/qcom/Makefile > @@ -12,6 +12,7 @@ qnoc-sdm845-objs := sdm845.o > qnoc-sdx55-objs := sdx55.o > qnoc-sm8150-objs := sm8150.o > qnoc-sm8250-objs := sm8250.o > +qnoc-sm8350-objs := sm8350.o > icc-smd-rpm-objs := smd-rpm.o icc-rpm.o > > obj-$(CONFIG_INTERCONNECT_QCOM_BCM_VOTER) += icc-bcm-voter.o > @@ -26,4 +27,5 @@ obj-$(CONFIG_INTERCONNECT_QCOM_SDM845) += qnoc-sdm845.o > obj-$(CONFIG_INTERCONNECT_QCOM_SDX55) += qnoc-sdx55.o > obj-$(CONFIG_INTERCONNECT_QCOM_SM8150) += qnoc-sm8150.o > obj-$(CONFIG_INTERCONNECT_QCOM_SM8250) += qnoc-sm8250.o > +obj-$(CONFIG_INTERCONNECT_QCOM_SM8350) += qnoc-sm8350.o > obj-$(CONFIG_INTERCONNECT_QCOM_SMD_RPM) += icc-smd-rpm.o > diff --git a/drivers/interconnect/qcom/sm8350.c b/drivers/interconnect/qcom/sm8350.c > new file mode 100644 > index 000000000000..55c76542aeff > --- /dev/null > +++ b/drivers/interconnect/qcom/sm8350.c > @@ -0,0 +1,636 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2019-2020, The Linux Foundation. All rights reserved. > + * Copyright (c) 2021, Linaro Limited > + * > + */ > + > +#include <linux/device.h> > +#include <linux/interconnect.h> > +#include <linux/interconnect-provider.h> > +#include <linux/module.h> > +#include <linux/of_device.h> > +#include <linux/of_platform.h> Is this used? Thanks, Georgi
