On Mon, Mar 15, 2021 at 02:39:33PM -0700, David Miller wrote: > From: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxx> > Date: Mon, 15 Mar 2021 13:29:17 +0200 > > > + > > +#define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK) > > +static int debug = -1; > > +module_param(debug, int, 0); > > +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); > > Module parameters are strongly discouraged in networking drivers, pplease delete this > ad just pass the default to netif_mdg_init(), thanks! Ups, I was not aware of this since I've seen it in quite a lot of drivers. Thanks for pointing this out, I will take care of it in the next revision. Kind regards, Cristi
