Hi Sebastian, Thanks for your input, I will and dump message into next version patch. Best Regards ********************************************** Li Qingwu (Terry) Senior Embedded Software Engineer Leica Geosystems(Shanghai)Co.,Limited (Tel): +86 21 61061036 (FAX): +86 21 61061008 (Mobile): +86 187 0185 9600 E-mail: Qing-wu.Li@xxxxxxxxxxxxxxxxxxxxxxx Http: www.leica-geosystems.com.cn ********************************************** -----Original Message----- From: Sebastian Reichel <sre@xxxxxxxxxx> Sent: Monday, March 15, 2021 7:42 AM To: LI Qingwu <qing-wu.li@xxxxxxxxxxxxxxxxxxxxxxx> Cc: robh+dt@xxxxxxxxxx; pali@xxxxxxxxxx; krzk@xxxxxxxxxx; afd@xxxxxx; linux-pm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; TERTYCHNYI Grygorii <grygorii.tertychnyi@xxxxxxxxxxxxxxxxxxxx>; ZHIZHIKIN Andrey <andrey.zhizhikin@xxxxxxxxxxxxxxxxxxxx> Subject: Re: [PATCH V5 0/2] power: bq27xxx: add bq78z100 Hi, On Fri, Mar 05, 2021 at 06:49:47AM +0000, LI Qingwu wrote: > Changes in V5: > > 1. Change [BQ27XXX_REG_TTES] from INVALID_REG_ADDR to 0x1c, the > StandbyTimeToEmpty command of bq78z100. > 2. Add [BQ27XXX_REG_RC] = 0x10. the RemainingCapacity command of > bq78z100. > 3. Set [BQ27XXX_REG_AE] to INVALID_REG_ADDR, support by bq78z100. > 4. Delete property POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG, not support by > bq78z100 I also asked to check other exposed properties and to provide a dump of the power-supply uevent in commit message or cover letter to verify chip works as expected. I cannot see the dump and you are exposing at least one property that always reports -ENODATA. I intentionally will not point out the exact property, so that you have to properly test your patch before submitting. Thanks, -- Sebastian > LI Qingwu (2): > dt-bindings: power: bq27xxx: add bq78z100 > power: supply: bq27xxx: Add support for BQ78Z100 > > .../bindings/power/supply/bq27xxx.yaml | 1 + > drivers/power/supply/bq27xxx_battery.c | 44 +++++++++++++++++++ > drivers/power/supply/bq27xxx_battery_i2c.c | 2 + > include/linux/power/bq27xxx_battery.h | 1 + > 4 files changed, 48 insertions(+) > > -- > 2.17.1 >
