Re: [PATCH 0/6] clk: Ingenic JZ4760(B) support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

On 2021/3/7 下午10:17, Paul Cercueil wrote:
Hi,

Here are a set of patches to add support for the Ingenic JZ4760(B) SoCs.

One thing to note is that the ingenic,jz4760-tcu is undocumented for now,
as I will update the TCU documentation in a different patchset.

Zhou: the CGU code now supports overriding the PLL M/N/OD calc
algorithm, please tell me if it works for you.


After set "od = 1;", the overriding works, but I think we still need some further improvements related to OD,

because there is no OD bits in the I2S PLL, this will cause error in "ingenic_pll_recalc_rate()", and may cause

"ingenic_pll_calc()" to also have error(if we will introduce support for non 1 od values).


I think maybe we can add codes to detect if there is an "pll_od_encoding". If it is NULL, it means no OD bits, then

do some corresponding processing( for example, setting corresponding variable to 1) to ensure proper calculation.


Thanks and best regards!


Cheers,
-Paul

Paul Cercueil (6):
   dt-bindings: clock: ingenic: Add ingenic,jz4760{,b}-cgu compatibles
   clk: Support bypassing dividers
   clk: ingenic: Read bypass register only when there is one
   clk: ingenic: Remove pll_info.no_bypass_bit
   clk: ingenic: Support overriding PLLs M/N/OD calc algorithm
   clk: ingenic: Add support for the JZ4760

  .../bindings/clock/ingenic,cgu.yaml           |   4 +
  drivers/clk/ingenic/Kconfig                   |  10 +
  drivers/clk/ingenic/Makefile                  |   1 +
  drivers/clk/ingenic/cgu.c                     |  92 ++--
  drivers/clk/ingenic/cgu.h                     |  12 +-
  drivers/clk/ingenic/jz4725b-cgu.c             |  12 +-
  drivers/clk/ingenic/jz4740-cgu.c              |  12 +-
  drivers/clk/ingenic/jz4760-cgu.c              | 433 ++++++++++++++++++
  drivers/clk/ingenic/jz4770-cgu.c              |  15 +-
  drivers/clk/ingenic/tcu.c                     |   2 +
  include/dt-bindings/clock/jz4760-cgu.h        |  54 +++
  11 files changed, 591 insertions(+), 56 deletions(-)
  create mode 100644 drivers/clk/ingenic/jz4760-cgu.c
  create mode 100644 include/dt-bindings/clock/jz4760-cgu.h




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux