Hi Wolfram,
On Fri, Mar 5, 2021 at 3:15 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Mar 04, 2021 at 04:32:54PM +0100, Geert Uytterhoeven wrote:
> > This patch series adds the device nodes for all I2C EEPROMs in the
> > Falcon board stack. As some EEPROMs are located on sub-boards,
> > it also introduces individual .dtsi files for these sub-boards.
> > Note that (for now) these sub-boards don't have compatible values or
> > model strings, as I think this needs more discussion.
> >
> > This has been tested on the Falcon boards in Magnus' and Kieran's farms.
> > The EEPROM on the CPU board in Magnus' farm contains some data.
> > All other EEPROMs are present, but in pristine state (all ones).
> >
> > Changes compared to v1:
> > - Move EEPROMs in sub-boards to separate .dtsi files and patches.
> >
>
> Checked the datasheets and tested, too, so:
>
> Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Tested-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Thanks!
> One minor question is: why do the labels in patches 2+3 have the "-id"
> suffix and patch 1 does not? Don't we want consistency here?
The EEPROMs on the sub-boards are labeled "Board ID" in the
schematics, the EEPROMs on the CPU and BreakOut board aren't.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
