Re: [PATCH v2 0/3] arm64: dts: renesas: falcon: Add I2C EEPROMs and sub-boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 04, 2021 at 04:32:54PM +0100, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> This patch series adds the device nodes for all I2C EEPROMs in the
> Falcon board stack.  As some EEPROMs are located on sub-boards,
> it also introduces individual .dtsi files for these sub-boards.
> Note that (for now) these sub-boards don't have compatible values or
> model strings, as I think this needs more discussion.
> 
> This has been tested on the Falcon boards in Magnus' and Kieran's farms.
> The EEPROM on the CPU board in Magnus' farm contains some data.
> All other EEPROMs are present, but in pristine state (all ones).
> 
> Changes compared to v1:
>   - Move EEPROMs in sub-boards to separate .dtsi files and patches.
> 

Checked the datasheets and tested, too, so:

Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Tested-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

One minor question is: why do the labels in patches 2+3 have the "-id"
suffix and patch 1 does not? Don't we want consistency here?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux