Hey Jagan, This looks good to me, feel free to add my r-b. Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx> On Thu, 4 Mar 2021 at 10:21, Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> wrote: > > ICN6211 is MIPI-DSI to RGB Converter bridge from Chipone. > > It has a flexible configuration of MIPI DSI signal input and > produces RGB565, RGB666, RGB888 output format. > > Add dt-bingings for it. > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > --- > Changes for v4: > - fixed Laurent comments > - added regulators > - replace reset with EN > - fixed warnings pointed by Robert > Changes for v3: > - updated to new dt-bindings style > > .../display/bridge/chipone,icn6211.yaml | 99 +++++++++++++++++++ > MAINTAINERS | 5 + > 2 files changed, 104 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > new file mode 100644 > index 000000000000..62c3bd4cb28d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > @@ -0,0 +1,99 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > + > +maintainers: > + - Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > + > +description: | > + ICN6211 is MIPI-DSI to RGB Converter bridge from chipone. > + > + It has a flexible configuration of MIPI DSI signal input and > + produce RGB565, RGB666, RGB888 output format. > + > +properties: > + compatible: > + enum: > + - chipone,icn6211 > + > + reg: > + maxItems: 1 > + description: virtual channel number of a DSI peripheral > + > + enable-gpios: > + description: Bridge EN pin, chip is reset when EN is low. > + > + vdd1-supply: > + description: A 1.8V/2.5V/3.3V supply that power the MIPI RX. > + > + vdd2-supply: > + description: A 1.8V/2.5V/3.3V supply that power the PLL. > + > + vdd3-supply: > + description: A 1.8V/2.5V/3.3V supply that power the RGB output. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Video port for MIPI DSI input > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Video port for MIPI DPI output (panel or connector). > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - enable-gpios > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + bridge@0 { > + compatible = "chipone,icn6211"; > + reg = <0>; > + enable-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* LCD-RST: PL5 */ > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + bridge_in_dsi: endpoint { > + remote-endpoint = <&dsi_out_bridge>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + bridge_out_panel: endpoint { > + remote-endpoint = <&panel_out_bridge>; > + }; > + }; > + }; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 9d241b832aae..065cbdc889d3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5529,6 +5529,11 @@ S: Maintained > F: Documentation/devicetree/bindings/display/panel/boe,himax8279d.yaml > F: drivers/gpu/drm/panel/panel-boe-himax8279d.c > > +DRM DRIVER FOR CHIPONE ICN6211 MIPI-DSI to RGB CONVERTER BRIDGE > +M: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > +S: Maintained > +F: Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > + > DRM DRIVER FOR FARADAY TVE200 TV ENCODER > M: Linus Walleij <linus.walleij@xxxxxxxxxx> > S: Maintained > -- > 2.25.1 >
