Hi Shubhrajyoti, Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx> wrote on Thu, 18 Feb 2021 10:19:44 +0530: > In the thread [1] Greg suggested that we move the driver > to the clk from the staging. > Add patches to address the concerns regarding the fractional and > set rate support in the TODO. > > The patch set does the following > - Trivial fixes for kernel doc. > - Move the driver to the clk folder > - Add capability to set rate. > - Add fractional support. > - Add support for configurable outputs. > - Make the output names unique so that multiple instances > do not crib. I think we prefer to move "clean" drivers out of the staging tree rather than "to be fixed" code. So I would invert the order of the patches in this series to make more sense: * 3/7-7/7 (various fixes/improvements) * 1/7 (bindings) * 2/7 (move to clk) > Shubhrajyoti Datta (7): > dt-bindings: add documentation of xilinx clocking wizard > clk: clock-wizard: Add the clockwizard to clk directory > clk: clock-wizard: Fix kernel-doc warning > clk: clock-wizard: Add support for dynamic reconfiguration > clk: clock-wizard: Add support for fractional support > clk: clock-wizard: Remove the hardcoding of the clock outputs > clk: clock-wizard: Update the fixed factor divisors > > .../bindings/clock/xlnx,clocking-wizard.yaml | 65 ++ > drivers/clk/Kconfig | 9 + > drivers/clk/Makefile | 1 + > drivers/clk/clk-xlnx-clock-wizard.c | 689 +++++++++++++++++++++ > drivers/staging/Kconfig | 2 - > drivers/staging/Makefile | 1 - > drivers/staging/clocking-wizard/Kconfig | 10 - > drivers/staging/clocking-wizard/Makefile | 2 - > drivers/staging/clocking-wizard/TODO | 12 - > .../clocking-wizard/clk-xlnx-clock-wizard.c | 333 ---------- > drivers/staging/clocking-wizard/dt-binding.txt | 30 - > 11 files changed, 764 insertions(+), 390 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > create mode 100644 drivers/clk/clk-xlnx-clock-wizard.c > delete mode 100644 drivers/staging/clocking-wizard/Kconfig > delete mode 100644 drivers/staging/clocking-wizard/Makefile > delete mode 100644 drivers/staging/clocking-wizard/TODO > delete mode 100644 drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c > delete mode 100644 drivers/staging/clocking-wizard/dt-binding.txt > Thanks, Miquèl