Hi, On Mon, Feb 15, 2021 at 11:22:33AM +0200, Leon Romanovsky wrote: > On Mon, Feb 15, 2021 at 04:28:09PM +0900, Nobuhiro Iwamatsu wrote: > > > > I have received your point out and have sent an email with the content > > to remove this line. But it may not have arrived yet... > > > > > Why did you use "def_bool y" and not "default y"? Isn't it supposed to be > > > "depends on STMMAC_ETH"? And probably it shouldn't be set as a default as "y". > > > > > > > The reason why "def_bool y" was set is that the wrong fix was left when > > debugging. Also, I don't think it is necessary to set "default y". > > This is also incorrect because it says "bool" Toshiba Visconti DWMAC > > support "". I change it to trustate in the new patch. > > > > And this driver is enabled when STMMAC_PLATFORM was Y. And STMMAC_PLATFORM > > depends on STMMAC_ETH. > > So I understand that STMMAC_ETH does not need to be dependents. Is this > > understanding wrong? > > This is correct understanding, just need to clean other entries in that > Kconfig that depends on STMMAC_ETH. OK, thanks. Best regards, Nobuhiro
