On Wednesday 10 February 2021 16:09:42 kostap@xxxxxxxxxxx wrote: > From: Grzegorz Jaszczyk <jaz@xxxxxxxxxxxx> > > Adding phy description to pcie, sata and usb will allow appropriate drivers > to configure marvell comphy-a3700 accordingly. > > Signed-off-by: Grzegorz Jaszczyk <jaz@xxxxxxxxxxxx> > Signed-off-by: Konstantin Porotchkin <kostap@xxxxxxxxxxx> Hello! This patch is not needed too as Gregory already included into his tree alternative patch which defines SATA PHY globally into main include file armada-37xx.dtsi: https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/commit/?h=for-next&id=6ece0f7dbd558670ec72ba390379949a4d4dc5c0 And PCIe and USB 3.0 PHY definitions are already in include file. > --- > arch/arm64/boot/dts/marvell/armada-3720-db.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-db.dts b/arch/arm64/boot/dts/marvell/armada-3720-db.dts > index 3e5789f37206..15e923f945d4 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-db.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-db.dts > @@ -132,11 +132,15 @@ > pinctrl-0 = <&pcie_reset_pins &pcie_clkreq_pins>; > reset-gpios = <&gpiosb 3 GPIO_ACTIVE_LOW>; > status = "okay"; > + /* Generic PHY, providing serdes lanes */ > + phys = <&comphy1 0>; > }; > > /* CON3 */ > &sata { > status = "okay"; > + /* Generic PHY, providing serdes lanes */ > + phys = <&comphy2 0>; > }; > > &sdhci0 { > @@ -217,4 +221,7 @@ > &usb3 { > status = "okay"; > usb-phy = <&usb3_phy>; > + /* Generic PHY, providing serdes lanes */ > + phys = <&comphy0 0>; > + phy-names = "usb"; > }; > -- > 2.17.1 >
