On pią, 2014-07-04 at 09:07 +0100, Mark Rutland wrote: > On Thu, Jul 03, 2014 at 12:44:34PM +0100, Krzysztof Kozlowski wrote: > > On czw, 2014-07-03 at 12:32 +0100, Mark Rutland wrote: > > > Hi, > > > > > > On Tue, Jul 01, 2014 at 08:02:00AM +0100, Krzysztof Kozlowski wrote: > > > > Add document describing device tree bindings for MAX14577 MFD > > > > drivers: MFD core, extcon, regulator and charger. > > > > > > > > Both MAX14577 and MAX77836 chipsets are documented. > > > > > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > > > > Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > > > Cc: Tomasz Figa <t.figa@xxxxxxxxxxx> > > > > Cc: devicetree@xxxxxxxxxxxxxxx > > > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > > > Cc: Pawel Moll <pawel.moll@xxxxxxx> > > > > Cc: Mark Rutland <mark.rutland@xxxxxxx> > > > > Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx> > > > > Cc: Kumar Gala <galak@xxxxxxxxxxxxxx> > > > > Reviewed-by: Tomasz Figa <t.figa@xxxxxxxxxxx> > > > > --- > > > > Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++++++++++++ > > > > 1 file changed, 152 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt > > > > new file mode 100644 > > > > index 000000000000..b235250a7b41 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/mfd/max14577.txt > > > > @@ -0,0 +1,152 @@ > > > > +Maxim MAX14577/77836 Multi-Function Device > > > > + > > > > +MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+ > > > > +Battery Charger and SFOUT LDO output for powering USB devices. It is > > > > +interfaced to host controller using I2C. > > > > + > > > > +MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge. > > > > + > > > > + > > > > +Required properties: > > > > +- compatible : Must be "maxim,max14577" or "maxim,max77836". > > > > +- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836) > > > > +- interrupts : IRQ line for the chip. > > > > +- interrupt-parent : The parent interrupt controller. > > > > + > > > > + > > > > +Required nodes: > > > > + - charger : > > > > + Node for configuring the charger driver. > > > > + Required properties: > > > > + - compatible : "maxim,max14577-charger" > > > > + or "maxim,max77836-charger" > > > > + - maxim,fast-charge-timer : Timer in hours to trigger the > > > > + INT3/MBCCHGERR interrupt; Valid values: > > > > + - 5, 6 or 7 (hours), > > > > + - 0 to disable. > > > > > > I'm not sure I follow what this is any why it should be in the DT. > > > > > > Could you explain what this is used for? > > > > Hi, > > > > These are settings for max14577 battery charger. Actually this > > particular setting does not look like board-specific but other (like > > battery voltage) do. > > > > The timer above is used by device to stop charging and to trigger > > interrupt. > > Ok. What I don't get is why this should be in the DT, it sounds like a > configuration option that would better be set at run time. I understand. I'll add this as sysfs entry and re-spin with version 3 of patchset. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
