On 2/5/21 5:52 AM, Nicolas Saenz Julienne wrote: > In BCM2711 the new ARGON ASB took over V3D. The old ASB is still present > with the ISP and H264 bits, and V3D is in the same place in the new ASB > as the old one. > > Use the fact that 'pm->arsan_asb' is populated as a hint that we're on > BCM2711. On top of that introduce the macro ASB_BASE() which will select > the correct ASB register base, based on whether we're trying to access > V3D and which platform we're on. Your subject has a typo, you most likely intended to write "Argon ASB", right? I will review the series a little later today. -- Florian