Hi Stephen, Missatge de Stephen Boyd <swboyd@xxxxxxxxxxxx> del dia dt., 2 de febr. 2021 a les 19:53: > > Some cros ECs support a front proximity MKBP event via > 'EC_MKBP_FRONT_PROXIMITY'. Add a DT binding to document this feature via > a node that is a child of the main cros_ec device node. Devices that > have this ability will describe this in firmware. > > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > Cc: Benson Leung <bleung@xxxxxxxxxxxx> > Cc: Guenter Roeck <groeck@xxxxxxxxxxxx> > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > Cc: Gwendal Grignou <gwendal@xxxxxxxxxxxx> > Cc: <devicetree@xxxxxxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> Thanks for adding a full example, IIRC this is preferred by Rob and we are also trying to apply this rule on all the cros-ec related bindings, so the dt_bindings_check really checks a full example. From my side looks good to me. Reviewed-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > --- > .../google,cros-ec-mkbp-proximity.yaml | 46 +++++++++++++++++++ > .../bindings/mfd/google,cros-ec.yaml | 3 ++ > 2 files changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/proximity/google,cros-ec-mkbp-proximity.yaml > > diff --git a/Documentation/devicetree/bindings/iio/proximity/google,cros-ec-mkbp-proximity.yaml b/Documentation/devicetree/bindings/iio/proximity/google,cros-ec-mkbp-proximity.yaml > new file mode 100644 > index 000000000000..d82b929af445 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/proximity/google,cros-ec-mkbp-proximity.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > + > +$id: http://devicetree.org/schemas/iio/proximity/google,cros-ec-mkbp-proximity.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ChromeOS EC MKBP Proximity Sensor > + > +maintainers: > + - Stephen Boyd <swboyd@xxxxxxxxxxxx> > + - Benson Leung <bleung@xxxxxxxxxxxx> > + - Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > + > +description: | > + Google's ChromeOS EC sometimes has the ability to detect user proximity. > + This is implemented on the EC as near/far logic and exposed to the OS > + via an MKBP switch bit. > + > +properties: > + compatible: > + const: google,cros-ec-mkbp-proximity > + > + label: > + description: Name for proximity sensor > + > +required: > + - compatible > + > +unevaluatedProperties: false > +additionalProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + ec@0 { > + compatible = "google,cros-ec-spi"; > + reg = <0>; > + proximity { > + compatible = "google,cros-ec-mkbp-proximity"; > + label = "proximity-wifi-lte"; > + }; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > index 76bf16ee27ec..479a9f15de32 100644 > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > @@ -94,6 +94,9 @@ properties: > keyboard-controller: > $ref: "/schemas/input/google,cros-ec-keyb.yaml#" > > + proximity: > + $ref: "/schemas/iio/proximity/google,cros-ec-mkbp-proximity.yaml#" > + > codecs: > type: object > additionalProperties: false > -- > https://chromeos.dev >
