On Thu, Jan 21, 2021 at 12:43 AM David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote: > > On Thu, Jan 21, 2021 at 09:47:57AM +0530, Viresh Kumar wrote: > > On 21-01-21, 11:44, David Gibson wrote: > > > On Wed, Jan 20, 2021 at 12:36:45PM +0530, Viresh Kumar wrote: > > > > This was copied from external DTC repository long back and isn't used > > > > anymore. Over that the dtc tool can be used to generate the dts source > > > > back from the dtb. Remove the unused fdtdump.c file. > > > > > > > > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> > > > > > > Doesn't this make updating the kernel dtc from upstream needlessly > > > more difficult? > > > > Hmm, I am not sure I understand the concern well. The kernel keeps a > > list of files[1] it needs to automatically copy (using a script) from > > the upstream dtc repo and fdtdump.c was never part of that. Keeping it > > there isn't going to make any difficulty I believe. > > Hm, ok. Seems a bit clunky compared to embedding the whole directory, > but whatever. Either way, it's a list of what to keep or what to omit as we don't want build files nor tests. If we were to take the whole thing, then we should do a submodule, but so far no one wants submodules in the kernel tree. There is a git subtree feature now that could do the same thing as the script. But the script is good enough only needing small tweaks occasionally, and anything else is work. Rob
