On 21-01-21, 11:44, David Gibson wrote: > On Wed, Jan 20, 2021 at 12:36:45PM +0530, Viresh Kumar wrote: > > This was copied from external DTC repository long back and isn't used > > anymore. Over that the dtc tool can be used to generate the dts source > > back from the dtb. Remove the unused fdtdump.c file. > > > > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> > > Doesn't this make updating the kernel dtc from upstream needlessly > more difficult? Hmm, I am not sure I understand the concern well. The kernel keeps a list of files[1] it needs to automatically copy (using a script) from the upstream dtc repo and fdtdump.c was never part of that. Keeping it there isn't going to make any difficulty I believe. -- viresh [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/dtc/update-dtc-source.sh