Hi,
On Wednesday 25 June 2014 02:44 PM, Zhangfei Gao wrote:
> From: Jiancheng Xue <xuejiancheng@xxxxxxxxxx>
>
> Add hix5hd2-sata-phy driver on Hisilicon hix5hd2 soc.
>
> Signed-off-by: Jiancheng Xue <xuejiancheng@xxxxxxxxxx>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
> ---
> drivers/phy/Kconfig | 8 ++
> drivers/phy/Makefile | 1 +
> drivers/phy/phy-hix5hd2-sata.c | 192 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 201 insertions(+)
> create mode 100644 drivers/phy/phy-hix5hd2-sata.c
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 16a2f06..782953d 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -109,6 +109,14 @@ config PHY_EXYNOS5250_SATA
> SATA 3.0 Gb/s, SATA 6.0 Gb/s speeds. It supports one SATA host
> port to accept one SATA device.
>
> +config PHY_HIX5HD2_SATA
> + tristate "HIX5HD2 SATA PHY Driver"
> + depends on ARCH_HIX5HD2 && OF
depends on HAS_IOMEM?
> + select GENERIC_PHY
> + select MFD_SYSCON
> + help
> + Support for SATA PHY on Hisilicon hix5hd2 Soc.
> +
> config PHY_SUN4I_USB
> tristate "Allwinner sunxi SoC USB PHY driver"
> depends on ARCH_SUNXI && HAS_IOMEM && OF
> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
> index b4f1d57..54f04d0 100644
> --- a/drivers/phy/Makefile
> +++ b/drivers/phy/Makefile
> @@ -12,6 +12,7 @@ obj-$(CONFIG_OMAP_USB2) += phy-omap-usb2.o
> obj-$(CONFIG_TI_PIPE3) += phy-ti-pipe3.o
> obj-$(CONFIG_TWL4030_USB) += phy-twl4030-usb.o
> obj-$(CONFIG_PHY_EXYNOS5250_SATA) += phy-exynos5250-sata.o
> +obj-$(CONFIG_PHY_HIX5HD2_SATA) += phy-hix5hd2-sata.o
> obj-$(CONFIG_PHY_SUN4I_USB) += phy-sun4i-usb.o
> obj-$(CONFIG_PHY_SAMSUNG_USB2) += phy-exynos-usb2.o
> phy-exynos-usb2-y += phy-samsung-usb2.o
> diff --git a/drivers/phy/phy-hix5hd2-sata.c b/drivers/phy/phy-hix5hd2-sata.c
> new file mode 100644
> index 0000000..6f1e3ea
> --- /dev/null
> +++ b/drivers/phy/phy-hix5hd2-sata.c
> @@ -0,0 +1,192 @@
> +/*
> + * Copyright (c) 2014 Linaro Ltd.
> + * Copyright (c) 2014 Hisilicon Limited.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/regmap.h>
> +#include <linux/phy/phy.h>
> +#include <linux/io.h>
> +#include <linux/platform_device.h>
> +#include <linux/delay.h>
can this be arranged alphabetically? Helps while adding new header files.
> +
> +#define SATA_PHY0_CTLL 0xa0
> +#define MPLL_MULTIPLIER_SHIFT 1
> +#define MPLL_MULTIPLIER_MASK 0xfe
> +#define MPLL_MULTIPLIER_50M 0x3c
> +#define MPLL_MULTIPLIER_100M 0x1e
> +#define PHY_RESET BIT(0)
> +#define REF_SSP_EN BIT(9)
> +#define SSC_EN BIT(10)
> +#define REF_USE_PAD BIT(23)
> +
> +#define SATA_PORT_PHYCTL 0x174
> +#define SPEED_MODE_MASK 0x6f0000
> +#define HALF_RATE_SHIFT 16
> +#define PHY_CONFIG_SHIFT 18
> +#define GEN2_EN_SHIFT 21
> +#define SPEED_CTRL BIT(20)
> +
> +#define SATA_PORT_PHYCTL1 0x148
> +#define AMPLITUDE_MASK 0x3ffffe
> +#define AMPLITUDE_GEN3 0x68
> +#define AMPLITUDE_GEN3_SHIFT 15
> +#define AMPLITUDE_GEN2 0x56
> +#define AMPLITUDE_GEN2_SHIFT 8
> +#define AMPLITUDE_GEN1 0x56
> +#define AMPLITUDE_GEN1_SHIFT 1
> +
.
.
<snip>
.
.
> +
> +static int hix5hd2_sata_phy_probe(struct platform_device *pdev)
> +{
> + struct phy_provider *phy_provider;
> + struct device *dev = &pdev->dev;
> + struct resource *res;
> + struct phy *phy;
> + struct hix5hd2_priv *priv;
> +
> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> + if (!priv)
> + return -ENOMEM;
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + priv->base = devm_ioremap(dev, res->start, resource_size(res));
> + if (!priv->base)
> + return -ENOMEM;
> +
> + priv->peri_ctrl = syscon_regmap_lookup_by_phandle(dev->of_node,
> + "hisilicon,peripheral-syscon");
> + if (IS_ERR(priv->peri_ctrl))
> + priv->peri_ctrl = NULL;
if syscon_regmap_lookup_by_phandle returns EPROBE_DEFER, you have to return
EPROBE_DEFER no?
Rest looks fine to me.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
