Hi Sachin, On 07/02/2014 12:09 PM, Sachin Kamat wrote: > On Wed, Jul 2, 2014 at 5:22 AM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote: >> On 07/01/2014 01:10 PM, Sachin Kamat wrote: >>> Hi Chanwoo, >>> >>> On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote: >>>> Hi Sachin, >>>> >>>> On 07/01/2014 12:33 PM, Sachin Kamat wrote: >>>>> Hi Chanwoo, >>>>> >>>>> On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote: >>>>>> This patch add TMU (Thermal Management Unit) dt node to monitor the high >>>>>> temperature for Exynos3250. >>>>>> >>>>>> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> >>>>>> Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> >>>>>> --- >>>>>> This patch has a dependency on following patch [1]: >>>>>> [1] https://lkml.org/lkml/2014/6/30/805 >>>>>> >>>>>> arch/arm/boot/dts/exynos3250.dtsi | 10 ++++++++++ >>>>>> 1 file changed, 10 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >>>>>> index 3660cab..1e566af 100644 >>>>>> --- a/arch/arm/boot/dts/exynos3250.dtsi >>>>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi >>>>>> @@ -192,6 +192,16 @@ >>>>>> status = "disabled"; >>>>>> }; >>>>>> >>>>>> + tmu: tmu@100C0000 { >>>>>> + compatible = "samsung,exynos3250-tmu"; >>>>>> + interrupt-parent = <&gic>; >>>>>> + reg = <0x100C0000 0x100>; >>>>>> + interrupts = <0 216 0>; >>>>>> + clocks = <&cmu CLK_TMU_APBIF>; >>>>>> + clock-names = "tmu_apbif"; >>>>>> + status = "disabled"; >>>>> >>>>> I don't think there would be any board specific properties needed. Hence >>>>> leave the status as enabled (by deleting the above line). >>>>> >>>> >>>> I think that if specific board need TMU feature, dts file for specific board >>>> should include tmu dt node with 'okay' status. The specific board based on >>>> Exynos3250 might not need TMU feature. >>> >>> The status field in DT node is not meant for stating the build configuration but >>> represents the readiness of the hardware for usage on the platform. If >>> a particular >>> board does not need this feature it needs to be disabled in the build >>> config and only >>> for any special requirements disable it in board file. >> >> TMU (Thermal Management Unit) needs specific regulator for TMU power as following: >> The regulator for TMU is dependent on board. > > In this case it makes sense to leave it disabled in dtsi. > Thanks for your review. Best Regards, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
