On Fri, Jun 27, 2014 at 08:00:35AM -0400, Jason Cooper wrote: > On Thu, Jun 26, 2014 at 12:40:31PM +0530, Sricharan R wrote: > > From: Nishanth Menon <nm@xxxxxx> > > > > Currently we attempt to map any crossbar value to an IRQ, however, > > this is not correct from hardware perspective. There is a max crossbar > > event number upto which hardware supports. So describe the same in > > device tree using 'ti,max-crossbar-sources' property and use it to > > validate requests. > > > > Signed-off-by: Nishanth Menon <nm@xxxxxx> > > Signed-off-by: Sricharan R <r.sricharan@xxxxxx> > > Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> > > --- > > .../devicetree/bindings/arm/omap/crossbar.txt | 2 ++ > > drivers/irqchip/irq-crossbar.c | 21 ++++++++++++++++++-- > > 2 files changed, 21 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/omap/crossbar.txt b/Documentation/devicetree/bindings/arm/omap/crossbar.txt > > index 5f45c78..6923531 100644 > > --- a/Documentation/devicetree/bindings/arm/omap/crossbar.txt > > +++ b/Documentation/devicetree/bindings/arm/omap/crossbar.txt > > @@ -10,6 +10,7 @@ Required properties: > > - compatible : Should be "ti,irq-crossbar" > > - reg: Base address and the size of the crossbar registers. > > - ti,max-irqs: Total number of irqs available at the interrupt controller. > > +- ti,max-crossbar-sources: Maximum number of crossbar sources that can be routed. > > - ti,reg-size: Size of a individual register in bytes. Every individual > > register is assumed to be of same size. Valid sizes are 1, 2, 4. > > - ti,irqs-reserved: List of the reserved irq lines that are not muxed using > > @@ -30,6 +31,7 @@ Examples: > > compatible = "ti,irq-crossbar"; > > reg = <0x4a002a48 0x130>; > > ti,max-irqs = <160>; > > + ti,max-crossbar-sources = <MAX_SOURCES>; > > As mentioned in my reply to #15, I can change this to 400 when I apply > it, or you can send a new version of #15 using the macro and explaining > it's definition. > > Thinking about it more, it's probably best just to use numbers in the > docs. I just did s/MAX_SOURCES/400/ when I applied this. We shouldn't be polluting the binding docs with implementation details. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
