On Thu, Jan 7, 2021 at 1:22 PM Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote: > > Config dsi node for mt8183 kukui. Set panel and ports. > > Several kukui boards share the same panel property and only compatible > is different. So compatible will be set in board dts for comparison > convenience. I like this, but maybe others have different opinions ,-) Reviewed-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx> > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> > --- > Change: > v2: move compatible to board dts > --- > .../mediatek/mt8183-kukui-krane-sku176.dts | 5 +++ > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 37 +++++++++++++++++++ > 2 files changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts > index 47113e275cb52..721d16f9c3b4f 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts > @@ -16,3 +16,8 @@ / { > model = "MediaTek krane sku176 board"; > compatible = "google,krane-sku176", "google,krane", "mediatek,mt8183"; > }; > + > +&panel { > + status = "okay"; > + compatible = "boe,tv101wum-nl6"; > +}; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > index bf2ad1294dd30..d3d20e4773cf1 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > @@ -249,6 +249,35 @@ &cpu7 { > proc-supply = <&mt6358_vproc11_reg>; > }; > > +&dsi0 { > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; > + panel: panel@0 { > + // compatible will be set in board dts > + reg = <0>; > + enable-gpios = <&pio 45 0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&panel_pins_default>; > + avdd-supply = <&ppvarn_lcd>; > + avee-supply = <&ppvarp_lcd>; > + pp1800-supply = <&pp1800_lcd>; > + port { > + panel_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + }; > + > + ports { > + port { > + dsi_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > +}; > + > &i2c0 { > pinctrl-names = "default"; > pinctrl-0 = <&i2c0_pins>; > @@ -547,6 +576,14 @@ pins_clk { > }; > }; > > + panel_pins_default: panel_pins_default { > + panel_reset { > + pinmux = <PINMUX_GPIO45__FUNC_GPIO45>; > + output-low; > + bias-pull-up; > + }; > + }; > + > pwm0_pin_default: pwm0_pin_default { > pins1 { > pinmux = <PINMUX_GPIO176__FUNC_GPIO176>; > -- > 2.29.2.729.g45daf8777d-goog >