Re: [PATCH 4/5] arch: arm64: dts: imx8mq/m/n/p: add mac address for FEC

[Shawn Guo <shawnguo@xxxxxxxxxx>]

On Thu, Nov 19, 2020 at 05:52:48PM +0800, Joakim Zhang wrote:
> Add mac address in efuse, so that FEC driver can parse it from nvmem
> cell.
> 
> Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 7 +++++++
>  arch/arm64/boot/dts/freescale/imx8mn.dtsi | 7 +++++++
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 7 +++++++
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 7 +++++++
>  4 files changed, 28 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index 367174031a90..0fbff13a9629 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -521,6 +521,10 @@
>  				cpu_speed_grade: speed-grade@10 {
>  					reg = <0x10 4>;
>  				};
> +
> +				fec_mac_address: mac-address@640 {

Shouldn't the unit-address be @90 rather than @640?

Shawn

> +					reg = <0x90 6>;
> +				};
>  			};
>  
>  			anatop: anatop@30360000 {
> @@ -917,6 +921,9 @@
>  				assigned-clock-rates = <0>, <100000000>, <125000000>, <0>;
>  				fsl,num-tx-queues = <3>;
>  				fsl,num-rx-queues = <3>;
> +				nvmem-cells = <&fec_mac_address>;
> +				nvmem-cell-names = "mac-address";
> +				nvmem_macaddr_swap;
>  				status = "disabled";
>  			};
>  
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index 7556b24b6467..6c16d09e47a5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -391,6 +391,10 @@
>  				cpu_speed_grade: speed-grade@10 {
>  					reg = <0x10 4>;
>  				};
> +
> +				fec_mac_address: mac-address@640 {
> +					reg = <0x90 6>;
> +				};
>  			};
>  
>  			anatop: anatop@30360000 {
> @@ -768,6 +772,9 @@
>  				assigned-clock-rates = <0>, <100000000>, <125000000>, <0>;
>  				fsl,num-tx-queues = <3>;
>  				fsl,num-rx-queues = <3>;
> +				nvmem-cells = <&fec_mac_address>;
> +				nvmem-cell-names = "mac-address";
> +				nvmem_macaddr_swap;
>  				status = "disabled";
>  			};
>  
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 3d9f5010769d..14176ee9a19c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -331,6 +331,10 @@
>  				cpu_speed_grade: speed-grade@10 {
>  					reg = <0x10 4>;
>  				};
> +
> +				eth_mac1: mac-address@640 {
> +					reg = <0x90 6>;
> +				};
>  			};
>  
>  			anatop: anatop@30360000 {
> @@ -770,6 +774,9 @@
>  				assigned-clock-rates = <0>, <100000000>, <125000000>, <0>;
>  				fsl,num-tx-queues = <3>;
>  				fsl,num-rx-queues = <3>;
> +				nvmem-cells = <&eth_mac1>;
> +				nvmem-cell-names = "mac-address";
> +				nvmem_macaddr_swap;
>  				status = "disabled";
>  			};
>  		};
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 8682a484dea5..6eb773fe6cec 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -558,6 +558,10 @@
>  				cpu_speed_grade: speed-grade@10 {
>  					reg = <0x10 4>;
>  				};
> +
> +				fec_mac_address: mac-address@640 {
> +					reg = <0x90 6>;
> +				};
>  			};
>  
>  			anatop: syscon@30360000 {
> @@ -1163,6 +1167,9 @@
>  				assigned-clock-rates = <0>, <100000000>, <125000000>, <0>;
>  				fsl,num-tx-queues = <3>;
>  				fsl,num-rx-queues = <3>;
> +				nvmem-cells = <&fec_mac_address>;
> +				nvmem-cell-names = "mac-address";
> +				nvmem_macaddr_swap;
>  				status = "disabled";
>  			};
>  		};
> -- 
> 2.17.1
>