On 18:07-20201216, Gowtham Tammana wrote:
> Add DT entries for main domain watchdog instances.
Please add a note to indicate that these are the only watchdogs that
are visible to Linux and ARMv8 systems.
You may need to repost the dts patch once you have the
>
> Signed-off-by: Gowtham Tammana <g-tammana@xxxxxx>
> ---
> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> index 72d6496e88dd..de430d44c2a6 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> @@ -303,6 +303,24 @@ main_uart9: serial@2890000 {
> clock-names = "fclk";
> };
>
> + watchdog0: watchdog@2200000 {
If you are going to strengthen the node-names up (recommend we
do that), you might want to use a regex and lock things down.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation//devicetree/bindings/watchdog/ti,rti-wdt.yaml#n26
That is much better option that expecting people to read the example and
follow the convention.
> + compatible = "ti,j7-rti-wdt";
> + reg = <0x0 0x2200000 0x0 0x100>;
we try and keep 0x00 instead of 0x0 -> see other places in the dtsi
> + clocks = <&k3_clks 252 1>;
> + power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
> + assigned-clocks = <&k3_clks 252 1>;
> + assigned-clock-parents = <&k3_clks 252 5>;
> + };
> +
> + watchdog1: watchdog@2210000 {
> + compatible = "ti,j7-rti-wdt";
> + reg = <0x0 0x2210000 0x0 0x100>;
> + clocks = <&k3_clks 253 1>;
> + power-domains = <&k3_pds 253 TI_SCI_PD_EXCLUSIVE>;
> + assigned-clocks = <&k3_clks 253 1>;
> + assigned-clock-parents = <&k3_clks 253 5>;
> + };
> +
> main_i2c0: i2c@2000000 {
> compatible = "ti,j721e-i2c", "ti,omap4-i2c";
> reg = <0x00 0x2000000 0x00 0x100>;
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
