On 06/27/2014 04:53 AM, Arnd Bergmann wrote:
On Thursday 26 June 2014 21:48:54 zhangfei wrote:
Since you mention that this is a synopsys part, it may however be
good to also define a compatible string for the generic device,
to allow other SoCs to share this driver, and to make it easier
for people to find out that we already have one so they don't have
to write another driver for the same hardware.
http://www.synopsys.com/dw/ipdir.php?ds=dwc_sata_phy
name can be: dwc_sata_phy
However, not find register from the website, not sure whether the
register are totally same, or there is some change.
Other soc from hisilicon using the same ip can share this driver.
I found a list of versions under "Downloads and Documentation", but
unfortunately the actual downloads are not accessible without a
customer account.
Can you find out what the Synopsys/Designware product designation for
this PHY is? It would be good to rename the driver and binding
if possible. I would still recommend leaving the
"hisilicon,hix5hd2-sata-phy" string and the "hisilicon,peripheral-syscon"
property in place, since that indicates a minor variation of the
generic part.
"hisilicon,peripheral-syscon" is privide power supply, etc.
Do you mean change the compatible to "hisilicon,dwc-sata-phy" or
multiple compatible?
Multiple compatible strings.
"hisilicon,dwc-sata-phy" would be too generic anyway, it should include the
name of the chip that first implements this, or the exact version of the
IP block, preferably both.
Ideally if you can find out the version that hisilicon uses, it could
look something like
compatible = "hisilicon,hi15hd2-sata-phy", "snps,dwc-sata-phy-2.3a", ""snps,dwc-sata-phy";
Note also the specific version of the hisilicon chip: you must not use
wildcards in compatible strings but should always use a real product number.
("1" instead of "x"). If multiple chips are mutually compatible, they
can all use the number of the first one here.
Sorry for the confusion.
The phy is rather an analog controller, without standard register.
Instead, the phy interface is just some pin / analog interface.
The register is in fact hix5hd2 register, controls all the analog
output, including reset, power, speed, para tunning.
Even the same phy is used in other soc, they can not share this driver,
since the connection must be different, as well as internal soc register
layout.
Only if the same controller & phy are reused in other hisilicon soc,
this driver can be shared.
Since what we control is hix5hd2 controller itself, so it may not
suitable to put snps here.
And about hix5hd2 name: x is not wildcard.
Currently hix5hd2 is series of hi3716c v200, hi3719c v100, hi3718c v100.
They are same soc, except minus pin assembles different.
However, not all hi37x is in this series, for example hi3716c v100 is a
different soc.
In the future hi3719m, hi3718m may also plan to add to hix5hd2 series.
The difference will be different cpu core number, different gpu core
number. Also use different ethernet controller.
So we may still keep "hisilicon,hix5hd2-sata-phy" unchanged.
What do you think?
Thanks
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
