On Wednesday 25 June 2014 20:41:26 zhangfei wrote: > On 06/25/2014 08:16 PM, Arnd Bergmann wrote: > > On Wednesday 25 June 2014, Zhangfei Gao wrote: > >> From: Jiancheng Xue <xuejiancheng@xxxxxxxxxx> > >> > >> Add necessary binding documentation SATA PHY on Hisilicon hix5hd2 soc. > >> > >> Signed-off-by: Jiancheng Xue <xuejiancheng@xxxxxxxxxx> > >> Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx> > > > > We have had a couple of PHY drivers that were initially meant to be > > single-purpose but then turned out to be for hardware that could > > be put into multiple modes (SATA, gbit ethernet, PCIe, ...). Are > > you sure that this particular device is SATA-only? > > > > Yes, double confimed. > Hix5hd2 phy diver only support sata phy, in fact, current soc only > support synposis phy, since some internal physical link. > And hix5hd2 ethernet phy is already in hix5hd2_gmac.c. > No pcie support on hix5hd2 platfrom. Sorry if I my question was unclear, I did not mean the implementation of this phy in hix5hd2, but the Synopsys phy itself. I was mainly asking because of the "compatible" string, which should otherwise not include "sata" but be more generic. Since you mention that this is a synopsys part, it may however be good to also define a compatible string for the generic device, to allow other SoCs to share this driver, and to make it easier for people to find out that we already have one so they don't have to write another driver for the same hardware. Can you find out what the Synopsys/Designware product designation for this PHY is? It would be good to rename the driver and binding if possible. I would still recommend leaving the "hisilicon,hix5hd2-sata-phy" string and the "hisilicon,peripheral-syscon" property in place, since that indicates a minor variation of the generic part. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
