Hello, I agree with you, but in the DTS file you put the angle, not the converted value. So 0 is the minimum, 315 the max even if it's not reflected in the configuration register. Thanks, Le mar. 15 déc. 2020 à 22:07, Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> a écrit : > > On Wed, Dec 16, 2020 at 2:19 AM Adrien Grassein > <adrien.grassein@xxxxxxxxx> wrote: > > > > nxp,phase-shift is an enum so use enum format to describe it. > > Minimum and maximum values are also wrong. > > > > Signed-off-by: Adrien Grassein <adrien.grassein@xxxxxxxxx> > > --- > > .../bindings/regulator/nxp,pf8x00-regulator.yaml | 16 ++++------------ > > 1 file changed, 4 insertions(+), 12 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml > > index 913532d0532e..1da724c6e2ba 100644 > > --- a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml > > +++ b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml > > @@ -60,21 +60,13 @@ properties: > > > > nxp,phase-shift: > > $ref: "/schemas/types.yaml#/definitions/uint32" > > - minimum: 45 > > - maximum: 0 > > + minimum: 0 > > + maximum: 315 > > + default: 0 > > + enum: [ 0, 45, 90, 135, 180, 225, 270, 315 ] > > Do you mean 0 is the minimum or starting value? I can see Table 48. > SWx phase configuration with minimum and maximum values are starting > from 45, 90, 135, 180, 225, 270, 315, 0 with phase bits as 0x0 to 0x7 > > Jagan.
