Hi Alexandru, Lars-Peter, On Fri, Nov 27, 2020 at 01:14:17PM +0200, Alexandru Ardelean wrote: > From: Lars-Peter Clausen <lars@xxxxxxxxxx> > > If no platform data is supplied use a dummy platform data that configures > the device in GPIO only mode. This change adds a adp5589_kpad_pdata_get() > helper that returns the default platform-data. This can be later extended > to load configuration from device-trees or ACPI. I was looking at this and I do not think it is a good idea, as later we will need to add negation if someone does nor want use GPIO mode. We should use the standard "gpio-controller" property from the beginning. Thanks. -- Dmitry