On Wed, Dec 09, 2020 at 05:04:59PM +0300, Ivan Mikhaylov wrote: > In KSZ9131 PHY it is possible to control LEDs blink behavior via > LED mode behavior and select registers. Add DTS properties plus handles > of them inside micrel PHY driver. > > I've some concerns about passing raw register values into LED mode > select and behavior. There was been some work done allowing PHY LEDs to be controlled just like other LEDs in Linux. That is how this should be done. Please go look back in the netdev and LED mailing list archives, and join that work. Andrew