Hi Michael,
On Sat, Dec 5, 2020 at 7:36 PM <michael.srba@xxxxxxxxx> wrote:
> From: Michael Srba <Michael.Srba@xxxxxxxxx>
>
> This patch adds the clock-frequency property to all device trees that use
> the imx219 binding, with the value of exactly 24Mhz which was previously
> implicitly assumed.
>
> Signed-off-by: Michael Srba <Michael.Srba@xxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
> @@ -82,6 +82,7 @@ imx219: imx219@10 {
> compatible = "sony,imx219";
> reg = <0x10>;
> clocks = <&osc25250_clk>;
> + clock-frequency = <24000000>;
> VANA-supply = <&imx219_vana_2v8>;
> VDIG-supply = <&imx219_vdig_1v8>;
> VDDL-supply = <&imx219_vddl_1v2>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
> index f0829e905506..db4b801b17b5 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
> @@ -59,6 +59,7 @@ &imx219 {
> port {
> imx219_ep: endpoint {
> clock-lanes = <0>;
> + clock-frequency = <24000000>;
Why is this change needed? This is not the imx219 node, but its endpoint
subnode (the imx219 is imported from aistarvision-mipi-adapter-2.1.dtsi).
> data-lanes = <1 2>;
> link-frequencies = /bits/ 64 <456000000>;
> /* uncomment remote-endpoint property to tie imx219 to
-
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
