On 03-12-20, 17:54, Bjorn Andersson wrote: > On Thu 03 Dec 01:09 CST 2020, Vinod Koul wrote: > > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c > [..] > > +static const int sm8350_reserved_gpios[] = { > > + 52, 53, 54, 55, 56, 57, 58, 59, -1 > > +}; > > Reserving these gpios here instead of in the DT means that there can > never be a platform configuration using these. Is there a good reason > for this? Or should we just mark them reserved in DT? So the question is are these gpios reserved per platform or for the SoC. Looking at this, seems former, so DT seems better suited. DO you agree? -- ~Vinod