On Thu, Dec 3, 2020 at 4:10 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Thu, Dec 3, 2020 at 4:00 PM Alexandru Ardelean > <alexandru.ardelean@xxxxxxxxxx> wrote: > > +#define SPI_NO_TX BIT(31) /* no transmit wire */ > > +#define SPI_NO_RX BIT(30) /* no receive wire */ > > +#define SPI_MODE_KERNEL_MASK (SPI_NO_TX | SPI_NO_RX) > > This needs a comment to explain what's going on with the flags (split). ...and to be consistent with proposal in uAPI: #define SPI_MODE_KERNEL_MASK (~(BIT(30) - 1)) -- With Best Regards, Andy Shevchenko
