Hi Russell, On Wed, 2 Dec 2020 at 00:04, Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx> wrote: > > On Tue, Dec 01, 2020 at 10:43:30PM +0900, Daniel Palmer wrote: > > + np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl"); > > + smpctrl = of_iomap(np, 0); > > + > > + if (!smpctrl) > > + return -ENODEV; > > Wouldn't -ENOMEM be more appropriate here? There seems to be examples of both -ENOMEM and -ENODEV in other ARM platforms. arch/arm/mach-aspeed/platsmp.c uses -ENODEV for example. I went with -ENODEV there as the source of the error is most likely the node not being in the device tree. I didn't check the result of of_find_compatible_node() because for the memory barrier code in the same file I was told it wasn't necessary. Thanks, Daniel
